Skip to content

Conversation

andyleejordan
Copy link
Member

The weekly CodeQL task requires being run as an official build, hence CodeQL was not yet running.
The easiest fix is to set the parameter controlling that to default to true, which means introducing another parameter controlling whether to release (which defaults to false).

The weekly CodeQL task requires being run as an official build,
hence CodeQL was not yet running.
The easiest fix is to set the parameter controlling that to default to true,
which means introducing another parameter controlling whether to release
(which defaults to false).
@andyleejordan andyleejordan requested a review from a team as a code owner October 7, 2025 22:41
@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 22:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the OneBranch pipeline to enable CodeQL scanning by default while maintaining control over release generation. The change addresses the requirement that CodeQL tasks must run as official builds by decoupling the official build setting from release control.

  • Changed OfficialBuild parameter default from false to true to enable CodeQL scanning
  • Added new Release parameter to control release generation independently
  • Updated release stage condition to use the new Release parameter instead of OfficialBuild

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andyleejordan andyleejordan enabled auto-merge (squash) October 7, 2025 22:41
@andyleejordan andyleejordan merged commit f505907 into main Oct 8, 2025
12 of 15 checks passed
@andyleejordan andyleejordan deleted the onebranch branch October 8, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants